Date: Fri, 28 Nov 2008 17:23:00 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Keith Packard <keithp@keithp.com>, linux-kernel@vger.kernel.org,
       Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] usb/serial: Add compat_ioctl pass-through
Message-ID: <20081128172300.0e30229e@infradead.org>
In-Reply-To: <20081129011057.14840d20@lxorguk.ukuu.org.uk>
References: <200811281642.52637.arnd@arndb.de>
	<1227911282-8857-1-git-send-email-keithp@keithp.com>
	<20081128223305.2d11f8d9@lxorguk.ukuu.org.uk>
	<1227920556.4277.128.camel@aiko.keithp.com>
	<20081129011057.14840d20@lxorguk.ukuu.org.uk>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 32

On Sat, 29 Nov 2008 01:10:57 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > Oh yes, it is -- serial_ioctl does:
> > 
> >         if (port->serial->type->ioctl) {
> >                 lock_kernel();
> >                 retval = port->serial->type->ioctl(tty, file, cmd,
> > arg); unlock_kernel();
> >         } else
> > 
> > I added the comment to make the difference in calling convention
> > documented in the header file at least, I didn't change the code.
> 
> Gak I thought I'd killed all of those.
> 
> Let me rephase it "It won't be next week" ;)

it's a double BKL since it's also using .ioctl not .unlocked_ioctl
(but then again we should just over time merge the two into a .ioctl
which is unlocked ;-)


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/