Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbYK2Gl0 (ORCPT ); Sat, 29 Nov 2008 01:41:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750901AbYK2GlS (ORCPT ); Sat, 29 Nov 2008 01:41:18 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:42221 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbYK2GlR (ORCPT ); Sat, 29 Nov 2008 01:41:17 -0500 Date: Fri, 28 Nov 2008 22:40:48 -0800 From: Andrew Morton To: Steven Rostedt Cc: Hugh Dickins , Pekka Enberg , "Rafael J. Wysocki" , Miles Lane , Linux Kernel Mailing List , Christoph Lameter , Ingo Molnar , Tejun Heo , Vegard Nossum , Arjan van de Ven , Frederic Weisbecker , Ingo Molnar Subject: Re: 2.6.28-rc6-git1 -- BUG: unable to handle kernel paging request at ffff8800be8b0019 Message-Id: <20081128224048.dbfc9082.akpm@linux-foundation.org> In-Reply-To: References: <200811270026.37941.rjw@sisk.pl> <84144f020811270537l3798b2f5ka63caacbee43b075@mail.gmail.com> <84144f020811270613t3f0258ddxac52abb9a447bf40@mail.gmail.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1783 Lines: 65 On Thu, 27 Nov 2008 18:31:34 -0500 (EST) Steven Rostedt wrote: > > [ Added Frederic ] > > On Thu, 27 Nov 2008, Hugh Dickins wrote: > > break; > > --- 2.6.28-rc6/include/linux/ftrace.h 2008-11-02 23:17:56.000000000 +0000 > > +++ linux/include/linux/ftrace.h 2008-11-27 16:39:26.000000000 +0000 > > @@ -231,7 +231,7 @@ ftrace_init_module(unsigned long *start, > > > > struct boot_trace { > > pid_t caller; > > - char func[KSYM_NAME_LEN]; > > + char func[KSYM_SYMBOL_LEN]; > > int result; > > unsigned long long duration; /* usecs */ > > ktime_t calltime; > > Acked-by: Steven Rostedt > > The boot tracer was written by Frederic. > This makes rather a mess when applied ahead of the (massive) ftrace changes in linux-next. afacit these two func[] arrays: --- /dev/null +++ b/include/trace/boot.h @@ -0,0 +1,56 @@ +#ifndef _LINUX_TRACE_BOOT_H +#define _LINUX_TRACE_BOOT_H + +/* + * Structure which defines the trace of an initcall + * while it is called. + * You don't have to fill the func field since it is + * only used internally by the tracer. + */ +struct boot_trace_call { + pid_t caller; + char func[KSYM_NAME_LEN]; +}; + +/* + * Structure which defines the trace of an initcall + * while it returns. + */ +struct boot_trace_ret { + char func[KSYM_NAME_LEN]; + int result; + unsigned long long duration; /* nsecs */ +}; will need to be changed to KSYM_SYMBOL_LEN. I think. Please fix it up carefully when this all lands on your doorstep. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/