Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbYK2Myp (ORCPT ); Sat, 29 Nov 2008 07:54:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751326AbYK2Myg (ORCPT ); Sat, 29 Nov 2008 07:54:36 -0500 Received: from mx2.suse.de ([195.135.220.15]:33474 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbYK2Myg (ORCPT ); Sat, 29 Nov 2008 07:54:36 -0500 From: Andreas Schwab To: roel kluin Cc: benh@kernel.crashing.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: powerpc: hv{cs,si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative References: <4931201D.7060701@gmail.com> X-Yow: Now KEN is having a MENTAL CRISIS because his "R.V." PAYMENTS are OVER-DUE!! Date: Sat, 29 Nov 2008 13:54:31 +0100 In-Reply-To: <4931201D.7060701@gmail.com> (roel kluin's message of "Sat, 29 Nov 2008 05:57:33 -0500") Message-ID: User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 26 roel kluin writes: > - if (--hvcsd->open_count == 0) { > + if (hvcsd->open_count == 1) { > + hvcsd->open_count--; This is not the same. > - if (--hp->count == 0) { > + if (hp->count == 1) { > + hp->count--; Likewise. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/