Date: Sat, 29 Nov 2008 18:56:45 +0000
From: Jamie Lokier <jamie@shareable.org>
To: =?iso-8859-1?Q?J=F6rn?= Engel <joern@logfs.org>
Cc: Matthew Wilcox <matthew@wil.cx>, Andrew Morton <akpm@linux-foundation.org>,
       Christoph Hellwig <hch@infradead.org>, Matthew Garrett <mjg@redhat.com>,
       Randy Dunlap <randy.dunlap@oracle.com>, linux-kernel@vger.kernel.org,
       linux-fsdevel@vger.kernel.org, mingo@redhat.com, val.henson@gmail.com
Subject: Re: [PATCH v2 2/2] relatime: Allow making relatime the default behaviour
Message-ID: <20081129185645.GA20194@shareable.org>
References: <20081126195457.GA3541@srcf.ucam.org> <20081126195824.GB3541@srcf.ucam.org> <492DD035.5020705@oracle.com> <20081127150126.GA20941@srcf.ucam.org> <20081127150341.GB20941@srcf.ucam.org> <20081127170345.GA14991@infradead.org> <20081129002419.abfd2504.akpm@linux-foundation.org> <20081129130308.GX25548@parisc-linux.org> <20081129135742.GC11959@logfs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20081129135742.GC11959@logfs.org>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1218
Lines: 28

J?rn Engel wrote:
> ...and check the tmpreaper manpage, you will notice that tmpreaper can
> be configured as well.  So relatime has a default timeout of T and
> tmpreaper is configured to delete files after 1/2 T (never mind what T
> might be), the system breaks.  Guessing a value of T that is good enough
> for everyone is a complicated business, so one configurable makes sense
> imo.
>
> One per mountpoint is rather silly, of course.

If it's configurable at all for tmpreaper (or similar), it should work
the same for tmpreaper in virtual machine containers.  (Same as,
e.g. utsname is different in containers).  If not now, someone will
have to patch it later.  Each VM runs it's own tmpreaper, configured
usually by separate people.

It's probably simpler to make it per-mountpoint than a virtualised global.

I don't see why there is an objection to per-mountpoint.
Andrew Morton's syntax: mount /dev/foo /mnt/bar -o relatime=86400
looks natural to me.

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/