Date: Sun, 30 Nov 2008 11:16:14 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Mackerras <paulus@samba.org>
Cc: roel kluin <roel.kluin@gmail.com>, benh@kernel.crashing.org,
       linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc: hv{cs, si}_close() both unsigned hp->count and
 hvcsd->open_count cannot be negative
Message-ID: <20081130111614.21b194c5@lxorguk.ukuu.org.uk>
In-Reply-To: <18737.52782.650416.444270@cargo.ozlabs.ibm.com>
References: <4931201D.7060701@gmail.com>
	<18737.52782.650416.444270@cargo.ozlabs.ibm.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 802
Lines: 14

> Also, I don't see why those changes have anything to do with "unsigned
> things cannot be negative".  As long as those counts are never zero on
> entry to those code sections, the existing code is fine, and I believe
> that assertion can be maintained.  If you believe the code needs to
> defend against the possibility of a zero count on entry, that should
> have been explicitly stated in the patch description.

See the tty_port patches in -next - this is an argument about code which
ought eventually to go away replaced by standard helper functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/