Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755229AbYK3N5Z (ORCPT ); Sun, 30 Nov 2008 08:57:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751569AbYK3N5Q (ORCPT ); Sun, 30 Nov 2008 08:57:16 -0500 Received: from ey-out-2122.google.com ([74.125.78.26]:11172 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbYK3N5Q (ORCPT ); Sun, 30 Nov 2008 08:57:16 -0500 Message-ID: Date: Sun, 30 Nov 2008 14:57:14 +0100 From: "Kay Sievers" To: "Al Viro" Subject: Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822 Cc: "Linus Torvalds" , gregkh@suse.de, petero2@telia.com, linux-kernel@vger.kernel.org In-Reply-To: <20081130135031.GB28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081130121909.GV28946@ZenIV.linux.org.uk> <20081130132118.GY28946@ZenIV.linux.org.uk> <20081130133229.GZ28946@ZenIV.linux.org.uk> <20081130134048.GA28946@ZenIV.linux.org.uk> <20081130135031.GB28946@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 33 On Sun, Nov 30, 2008 at 14:50, Al Viro wrote: > On Sun, Nov 30, 2008 at 02:44:24PM +0100, Kay Sievers wrote: > >> >> Which part of the above constitutes a creation of char device node? >> > >> > Wait a minute... Are you saying that something in userland ends up >> > seeing that sucker, noticing .../dev and proceeding to do mknod? >> >> Sure, it does mkod, as the kernel says it should. But that does not >> cause any real problem. > > "It" being udev, presumably? Yes, udev, mdev, and a few other tools people use to populate /dev from the kernel supplied device information. > What a mess... How does drivers/usb/core/devio.c avoid essentially the same > problem? It's a special case, where two "struct device" have the same dev_t, but they both point to and handle the same device, so it's fine. The usb_device class is deprecated, no recent distro uses it, and will be removed some day. The /sys/dev/ is handled properly by doing: usb_classdev_class->dev_kobj = NULL; Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/