Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755487AbYK3Owf (ORCPT ); Sun, 30 Nov 2008 09:52:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751096AbYK3OwZ (ORCPT ); Sun, 30 Nov 2008 09:52:25 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:49849 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbYK3OwZ (ORCPT ); Sun, 30 Nov 2008 09:52:25 -0500 Date: Sun, 30 Nov 2008 14:52:21 +0000 From: Al Viro To: Kay Sievers Cc: Linus Torvalds , gregkh@suse.de, petero2@telia.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822 Message-ID: <20081130145221.GD28946@ZenIV.linux.org.uk> References: <20081130132118.GY28946@ZenIV.linux.org.uk> <20081130133229.GZ28946@ZenIV.linux.org.uk> <20081130134048.GA28946@ZenIV.linux.org.uk> <20081130135031.GB28946@ZenIV.linux.org.uk> <20081130141329.GC28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 15 On Sun, Nov 30, 2008 at 03:28:15PM +0100, Kay Sievers wrote: > > So we need to preserve the layout, with the easiest way probably being "add > > one more ktype and use kobject_init_and_add() instead of that device_create()". > > Sigh... > > What do you mean? We just need to replace the bogus "pd->pkt_dev" with > MKDEV(0, 0) and we are fine. Userland-visible change - right now cat /sys/class/pktcdvd/pktcdvd3/dev will give you dev_t of the block device in question. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/