Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755487AbYK3RlA (ORCPT ); Sun, 30 Nov 2008 12:41:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751890AbYK3Rku (ORCPT ); Sun, 30 Nov 2008 12:40:50 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:52270 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbYK3Rkt (ORCPT ); Sun, 30 Nov 2008 12:40:49 -0500 Date: Sun, 30 Nov 2008 18:40:34 +0100 From: Ingo Molnar To: Mahesh Salgaonkar Cc: Linux Kernel , Suresh B Siddha , Venkatesh Pallipadi , Peter Zijlstra Subject: Re: [PATCH] Don't export sched_mc_power_savings in laptops Message-ID: <20081130174034.GA28614@elte.hu> References: <1227957612-7000-1-git-send-email-mahesh@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1227957612-7000-1-git-send-email-mahesh@linux.vnet.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 33 * Mahesh Salgaonkar wrote: > Fix to prevent sched_mc_power_saving from being exported through sysfs > for multicore single socket (Laptop). > > CPU core map of the boot cpu should be equal to possible number > of cpus for single socket system. > > This fix has been developed at FOSS.in kernel workout. > > Signed-off-by: Mahesh Salgaonkar > > diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h > index 4850e4b..4adc830 100644 > --- a/arch/x86/include/asm/topology.h > +++ b/arch/x86/include/asm/topology.h > @@ -239,7 +239,7 @@ struct pci_bus; > void set_pci_bus_resources_arch_default(struct pci_bus *b); > > #ifdef CONFIG_SMP > -#define mc_capable() (boot_cpu_data.x86_max_cores > 1) > +#define mc_capable() (cpus_weight(per_cpu(cpu_core_map,0)) != nr_cpu_ids) hm, dunno. sched_mc_power_savings should have no effect on single-socket systems, right? So the knob should have no effect. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/