Date: Sun, 30 Nov 2008 19:58:05 +0100
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: Artem Bityutskiy <dedekind@infradead.org>, linux-fsdevel@vger.kernel.org,
       linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
       Ivan Kokshaysky <ink@jurassic.park.msu.ru>, akpm@linux-foundation.org
Subject: Re: [PATCH] UBIFS: fix compilation warnings
Message-ID: <20081130185805.GB2839@Chamillionaire.breakpoint.cc>
References: <1227287970-14684-1-git-send-email-dedekind@infradead.org> <1227287970-14684-5-git-send-email-dedekind@infradead.org> <20081122185429.GA21433@Chamillionaire.breakpoint.cc> <492A7BFD.7000206@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <492A7BFD.7000206@nokia.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1265
Lines: 37

* Adrian Hunter | 2008-11-24 12:03:41 [+0200]:

> Doesn't help:
>
> fs/ubifs/journal.c:699: warning: format ???%zu??? expects type 
> ???size_t???, but argument 4 has type ???ino_t???
Indeed. BUT:

Is there actually a reason why Alpha is the only arch having
__kernel_ino_t defined as unsigned int instead of unsigned long ?
(except s390 in 32bit mode).

I just checked and I haven't seen anything that would point out that
__kernel_ino_t / ino_t is part of user space API.
What I've found instead is for instance that ext2 relies that ino_t is a
long:

|struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
|{
....
|        raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);

and the prototype is:
|static struct ext2_inode *ext2_get_inode(struct super_block *sb, ino_t ino,
|                                         struct buffer_head **p)

So we lose the upper 32bit on Alpha. Unless the whole system is
self-contained and the ext2_iget() user never passes something > ino_t.

Any comments?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/