Date: Mon, 1 Dec 2008 10:37:41 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: mmotm 2008-11-26-17-00 uploaded (hwmon / dev_attr_name)
Message-Id: <20081201103741.f70cb84c.akpm@linux-foundation.org>
In-Reply-To: <20081201135634.GC6932@gundam.enneenne.com>
References: <200811270101.mAR114rp016378@imap1.linux-foundation.org>
	<4930CCA9.9070505@oracle.com>
	<20081128220659.2d5049e6.akpm@linux-foundation.org>
	<49317AF9.5030409@oracle.com>
	<20081130215350.b63ed292.akpm@linux-foundation.org>
	<20081201135634.GC6932@gundam.enneenne.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1363
Lines: 30

On Mon, 1 Dec 2008 14:56:34 +0100 Rodolfo Giometti <giometti@enneenne.com> wrote:

> We can just remove the DEVICE_ATTR(name, ...) since all the variables
> are into pps_attrs[].
> 
> Please, let me know if you wish a proper patch for this or you can do
> it by yourself.

I'll sort it out.

> > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_dcd_change':
> > drivers/pps/clients/pps-ldisc.c:32: warning: cast from pointer to integer of different size
> > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_open':
> > drivers/pps/clients/pps-ldisc.c:77: warning: cast to pointer from integer of different size
> > drivers/pps/clients/pps-ldisc.c:82: warning: cast from pointer to integer of different size
> > drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_close':
> > drivers/pps/clients/pps-ldisc.c:91: warning: cast from pointer to integer of different size
> > 
> > 
> > For the ->disc_data warnings you could perhaps just make all the
> > relevant scalar types `long', not `int'.
> 
> But doing like this will breaks 32bit archs... =:-o

I don't think so.  sizeof(long) == sizeof(int) on 32-bit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/