Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753376AbYLAWka (ORCPT ); Mon, 1 Dec 2008 17:40:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752789AbYLAWkV (ORCPT ); Mon, 1 Dec 2008 17:40:21 -0500 Received: from sovereign.computergmbh.de ([85.214.69.204]:48444 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbYLAWkU (ORCPT ); Mon, 1 Dec 2008 17:40:20 -0500 Date: Mon, 1 Dec 2008 23:40:18 +0100 (CET) From: Jan Engelhardt To: John Haxby cc: Netfilter Development Mailinglist , Linux Kernel Mailing List Subject: sg_set_page not usable for .bss? In-Reply-To: <49345EE4.3070409@oracle.com> Message-ID: References: <492E926D.5020807@oracle.com> <49345EE4.3070409@oracle.com> User-Agent: Alpine 1.10 (LNX 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 31 On Monday 2008-12-01 23:02, John Haxby wrote: >>>+ sg_init_table(sg, 2); >>>+ sg_set_buf(&sg[0], data, n); >>>+ strcpy(digest_password, sysrq_password); >>>+ i = strlen(digest_password); >>>+ sg_set_buf(&sg[1], digest_password, i); >> >> Could we directly use sysrq_password instead of copying it to >> digest_password first? > > No :-) Eventually I discovered the reason my code wasn't working > boils down to the definition of sg_set_buf: > > sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf)) > > which doesn't work for sysrq_password. I don't know why I'll > double check. Well, sysrq_password is in the .bss section, where as digest_password is on the heap due to being kmalloc'ed. Maybe that makes a difference? Someone more versed with the virtual memory layer might know. >+static char sysrq_password[64]; >[...] >+ digest_password = kmalloc(sizeof(sysrq_password), GFP_KERNEL); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/