Date: Mon, 01 Dec 2008 16:10:26 -0800 (PST)
Message-Id: <20081201.161026.234536822.davem@davemloft.net>
To: jengelh@medozas.de
Cc: john.haxby@oracle.com, netfilter-devel@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: sg_set_page not usable for .bss?
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.LNX.1.10.0812012338270.22349@fbirervta.pbzchgretzou.qr>
References: <alpine.LNX.1.10.0812011952520.17726@fbirervta.pbzchgretzou.qr>
	<49345EE4.3070409@oracle.com>
	<alpine.LNX.1.10.0812012338270.22349@fbirervta.pbzchgretzou.qr>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1235
Lines: 32

From: Jan Engelhardt <jengelh@medozas.de>
Date: Mon, 1 Dec 2008 23:40:18 +0100 (CET)

> 
> On Monday 2008-12-01 23:02, John Haxby wrote:
> >>>+	sg_init_table(sg, 2);
> >>>+	sg_set_buf(&sg[0], data, n);
> >>>+	strcpy(digest_password, sysrq_password);
> >>>+	i = strlen(digest_password);
> >>>+	sg_set_buf(&sg[1], digest_password, i);
> >>
> >> Could we directly use sysrq_password instead of copying it to
> >> digest_password first?
> >
> > No :-)   Eventually I discovered the reason my code wasn't working
> > boils down to the definition of sg_set_buf:
> >
> >   sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf))
> >
> > which doesn't work for sysrq_password.   I don't know why I'll
> > double check.
> 
> Well, sysrq_password is in the .bss section, where as digest_password
> is on the heap due to being kmalloc'ed. Maybe that makes a difference?
> Someone more versed with the virtual memory layer might know.

You can't use these interfaces on kernel image addresses.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/