Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753388AbYLBA5T (ORCPT ); Mon, 1 Dec 2008 19:57:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752177AbYLBA5J (ORCPT ); Mon, 1 Dec 2008 19:57:09 -0500 Received: from ozlabs.org ([203.10.76.45]:40355 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752075AbYLBA5I (ORCPT ); Mon, 1 Dec 2008 19:57:08 -0500 From: Rusty Russell To: Andrew Morton Subject: Re: 2.6.28-rc6-git1 -- BUG: unable to handle kernel paging request at ffff8800be8b0019 Date: Tue, 2 Dec 2008 11:27:02 +1030 User-Agent: KMail/1.10.1 (Linux/2.6.27-9-generic; KDE/4.1.2; i686; ; ) Cc: Hugh Dickins , penberg@cs.helsinki.fi, rjw@sisk.pl, miles.lane@gmail.com, linux-kernel@vger.kernel.org, cl@linux-foundation.org, mingo@elte.hu, htejun@gmail.com, vegard.nossum@gmail.com, rostedt@goodmis.org, arjan@infradead.org References: <20081201125103.db4c026f.akpm@linux-foundation.org> In-Reply-To: <20081201125103.db4c026f.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200812021127.03631.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 737 Lines: 18 On Tuesday 02 December 2008 07:21:03 Andrew Morton wrote: > The fault really lies with include/linux/kallsyms.h, I think: > > #define KSYM_SYMBOL_LEN (sizeof("%s+%#lx/%#lx [%s]") + (KSYM_NAME_LEN - 1) > + \ 2*(BITS_PER_LONG*3/10) + (MODULE_NAME_LEN - 1) + 1) Hmm... and I recently define MODULE_NAME_LEN in terms of MAX_PARAM_PREFIX_LEN for similar reasons. Perhaps we should move MODULE_NAME_LEN to kernel.h and define everything in terms of that? It seems to be a common need. Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/