Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbYLBDoA (ORCPT ); Mon, 1 Dec 2008 22:44:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751388AbYLBDnu (ORCPT ); Mon, 1 Dec 2008 22:43:50 -0500 Received: from hera.kernel.org ([140.211.167.34]:41073 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbYLBDnt (ORCPT ); Mon, 1 Dec 2008 22:43:49 -0500 Message-ID: <4934AEF1.4080009@kernel.org> Date: Tue, 02 Dec 2008 12:43:45 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.17 (X11/20080922) MIME-Version: 1.0 To: "Nicholas A. Bellinger" CC: FUJITA Tomonori , Mike Anderson , Mike Christie , Christoph Hellwig , James Bottomley , Andrew Morton , Alan Stern , Hannes Reinecke , Boaz Harrosh , Jens Axboe , linux-scsi , LKML , "Linux-iSCSI.org Target Dev" Subject: Re: Changes to Linux/SCSI target mode infrastructure for v2.6.28 References: <1228182727.13241.160.camel@haakon2.linux-iscsi.org> <1228183480.13241.163.camel@haakon2.linux-iscsi.org> <1228187439.13241.176.camel@haakon2.linux-iscsi.org> <1228188330.13241.184.camel@haakon2.linux-iscsi.org> In-Reply-To: <1228188330.13241.184.camel@haakon2.linux-iscsi.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Tue, 02 Dec 2008 03:43:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 43 Hello, Nicholas. Nicholas A. Bellinger wrote: > Ok, I am up and running using the following patch against v2.6.28-rc6 > (along with Tejun's patch). Comments please..? > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index f5d3b96..77f1fe0 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -1505,7 +1507,7 @@ static void scsi_kill_request(struct request *req, struct request_queue *q) > struct scsi_target *starget = scsi_target(sdev); > struct Scsi_Host *shost = sdev->host; > > - blkdev_dequeue_request(req); > + elv_dequeue_request(req->q, req); I don't think this really matters. Either one wouldn't really matter. > if (unlikely(cmd == NULL)) { > printk(KERN_CRIT "impossible request in %s.\n", > @@ -1634,7 +1636,7 @@ static void scsi_request_fn(struct request_queue *q) > * Remove the request from the request list. > */ > if (!(blk_queue_tagged(q) && !blk_queue_start_tag(q, req))) > - blkdev_dequeue_request(req); > + elv_dequeue_request(req->q, req); > sdev->device_busy++; > > spin_unlock(q->queue_lock); And this change is incorrect. Timer should start here. I don't think you're seeing the same problem. I'll reply to the original message. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/