Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753467AbYLBIbA (ORCPT ); Tue, 2 Dec 2008 03:31:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751631AbYLBIau (ORCPT ); Tue, 2 Dec 2008 03:30:50 -0500 Received: from smtp123.sbc.mail.sp1.yahoo.com ([69.147.64.96]:39981 "HELO smtp123.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751584AbYLBIau (ORCPT ); Tue, 2 Dec 2008 03:30:50 -0500 X-Yahoo-Newman-Property: ymail-3 Subject: Re: Changes to Linux/SCSI target mode infrastructure for v2.6.28 From: "Nicholas A. Bellinger" To: Mike Anderson Cc: Tejun Heo , FUJITA Tomonori , Mike Christie , Christoph Hellwig , James Bottomley , Andrew Morton , Alan Stern , Hannes Reinecke , Boaz Harrosh , Jens Axboe , linux-scsi , LKML , "Linux-iSCSI.org Target Dev" In-Reply-To: <20081202064036.GC14025@linux.vnet.ibm.com> References: <1228182727.13241.160.camel@haakon2.linux-iscsi.org> <1228183480.13241.163.camel@haakon2.linux-iscsi.org> <1228187439.13241.176.camel@haakon2.linux-iscsi.org> <4934B71C.4030907@kernel.org> <1228194335.6229.17.camel@haakon2.linux-iscsi.org> <20081202064036.GC14025@linux.vnet.ibm.com> Content-Type: text/plain Date: Tue, 02 Dec 2008 00:30:46 -0800 Message-Id: <1228206646.6229.46.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1811 Lines: 42 On Mon, 2008-12-01 at 22:40 -0800, Mike Anderson wrote: > Nicholas A. Bellinger wrote: > > On Tue, 2008-12-02 at 13:18 +0900, Tejun Heo wrote: > > > > > > >>> The other one is a BUG_ON in blk/blk-timeout.c:177 in blk_add_timeout() > > > >>> that happens after a few hundred MB of READ_10 traffic, which also > > > >>> appears to pass through elv_dequeue_request() at some point: > > > >>> > > > >>> http://linux-iscsi.org/builds/user/nab/2.6.28-rc6-oops-2.png > > > >>> http://linux-iscsi.org/builds/user/nab/2.6.28-rc6-oops-4.png > > > > > > Hmmm... this means blk_add_timer() is being called after the request > > > is already completed. > > or is it possible since elv_dequeue_request BUG_ON check of queuelist did > not trigger a request is on the queuelist with a timeout_list not empty. > > It would be interesting for a debug run to change the > "BUG_ON(!list_empty(&req->timeout_list))" in blk_add_timer to print out > the cmd_flags plus req->atomic_flags and also add a > "BUG_ON(!list_empty(&rq->timeout_list))" to elv_insert to ensure a request > is never added to the queuelist with a timeout_list not empty. > Ok, so blk_dump_rq_flags() is now being called in block/blk-timeout.c:blk_add_timer() for the case BUG_ON(list_empty(&req->timeout_list)) case: http://linux-iscsi.org/builds/user/nab/2.6.28-rc6-oops-6.png Hmm, the outputted "sector " range is definately is bogus, as the only READ_10 that have been sent are at LBA offset 0 for 8 * 512 byte sectors for the partition table during Open/iSCSI LUN scanning. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/