Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754762AbYLBNRs (ORCPT ); Tue, 2 Dec 2008 08:17:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753807AbYLBNRk (ORCPT ); Tue, 2 Dec 2008 08:17:40 -0500 Received: from nlpi025.sbcis.sbc.com ([207.115.36.54]:42959 "EHLO nlpi025.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753407AbYLBNRj (ORCPT ); Tue, 2 Dec 2008 08:17:39 -0500 Date: Tue, 2 Dec 2008 07:12:01 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@quilx.com To: Hugh Dickins cc: Andrew Morton , Russ Anderson , Nick Piggin , Dave Jones , Arjan van de Ven , Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/8] badpage: simplify page_alloc flag check+clear In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -2.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 26 On Tue, 2 Dec 2008, Hugh Dickins wrote: > > But they are always clear on free. The checking is irrelevant. > > How about CHECK_PAGE_FLAGS_CLEAR_AT_FREE? Strange name. > The one I really disliked was "PAGE_FLAGS" for an obscure > subset of page flags, and have got rid of that. Good. > > If (page->flags & (all the flags including dirty and SwapBacked)) > > zap-em. > > That's exactly what I did, isn't it? Yes but you added another instance of this. Can you consolidate all the check and clears into one? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/