Return-Path: <linux-kernel-owner+w=401wt.eu-S1754474AbYLBUGZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754474AbYLBUGZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Dec 2008 15:06:25 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751455AbYLBUF6
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 2 Dec 2008 15:05:58 -0500
Received: from cavan.codon.org.uk ([93.93.128.6]:50675 "EHLO
	vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751337AbYLBUF4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Dec 2008 15:05:56 -0500
Date: Tue, 2 Dec 2008 20:05:45 +0000
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Matt_Domsch@dell.com, greg@kroah.com,
       linux-acpi@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
       Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 2/2] misc: Add dell-laptop driver
Message-ID: <20081202200544.GA31620@srcf.ucam.org>
References: <20081127163357.GA22846@srcf.ucam.org> <20081127163444.GB22846@srcf.ucam.org> <20081202115029.2b9d1153.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081202115029.2b9d1153.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.12-2006-07-14
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: mjg59@codon.org.uk
X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1581
Lines: 53

On Tue, Dec 02, 2008 at 11:50:29AM -0800, Andrew Morton wrote:
> > +struct calling_interface_buffer {
> > +	u16 class;
> > +	u16 select;
> > +	volatile u32 input[4];
> > +	volatile u32 output[4];
> > +} __attribute__ ((packed));
> 
> We have that little __packed helper for this.

Ok. I've switched to that, although the __attribute__ notation seems to 
be the dominant form in the kernel right now.

> > +static struct dmi_system_id __initdata dell_device_table[] = {
> 
> this can be made const.

Done.

> > +	da_num_tokens += tokens;
> > +}
> 
> OK.  No locking is needed for updates to the global state?

The parse function is called once during module init, before the driver 
is registered. On the other hand, that makes me realise that we leak it 
if something else fails, so I've fixed that up as well.

> > +#ifdef CONFIG_ACPI
> > +	if (acpi_video_backlight_support())
> > +		return 0;
> > +#endif
> 
> Do we need the ifdefs here?  It looks like include/linux/acpi.h tries
> to provide a suitable 0-returning stub?

They're protected by #ifdef CONFIG_ACPI_VIDEO, but it looks like acpi.h 
is empty if CONFIG_ACPI isn't set?

> > +			dell_backlight_device = NULL;
> > +			ret = PTR_ERR(dell_backlight_device);
> 
> The above two statements are in the wrong order.

Good catch, thanks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/