Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753689AbYLCMac (ORCPT ); Wed, 3 Dec 2008 07:30:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751382AbYLCMaX (ORCPT ); Wed, 3 Dec 2008 07:30:23 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:59756 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbYLCMaW (ORCPT ); Wed, 3 Dec 2008 07:30:22 -0500 Date: Wed, 3 Dec 2008 07:30:21 -0500 From: Christoph Hellwig To: Mimi Zohar Cc: linux-kernel@vger.kernel.org, Andrew Morton , James Morris , Christoph Hellwig , Al Viro , David Safford , Serge Hallyn , Mimi Zohar Subject: Re: [PATCH 2/6] integrity: Linux Integrity Module(LIM) Message-ID: <20081203123021.GA30035@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 45 On Tue, Dec 02, 2008 at 04:47:56PM -0500, Mimi Zohar wrote: > +/* > + * Integrity API calls: > + * > + * @collect_measurement: > + * Collect template specific measurement data. > + * @data contains template specific data used for collecting the > + * measurement. > + * Return 0 if operation was successful. > + * > + * @appraise_measurement: > + * Appraise the integrity of the template specific measurement data. > + * @data contains template specific data used for appraising the > + * measurement. > + * Return 0 if operation was successful. > + * > + * @store_measurement: > + * Store the template specific data. > + * @data contains template specific data used for storing the > + * measurement. > + * > + * @store_template: > + * Store the entry containing the template specific data. > + * @data contains template name, data length, and data. > + * > + * @must_measure: > + * Measurement decision based on an integrity policy. > + * @data contains template specific data used for making policy > + * decision. > + * Return 0 if operation was successful. > + * > + * @display_template: > + * Display template specific data. > + * > + */ Can you explain what all this template stuff is about? The only method of these ever called is display_template, and that seems to be better implented directly as a securityfs file, without the indirection. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/