Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753677AbYLCMxG (ORCPT ); Wed, 3 Dec 2008 07:53:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752251AbYLCMwy (ORCPT ); Wed, 3 Dec 2008 07:52:54 -0500 Received: from extu-mxob-2.symantec.com ([216.10.194.135]:56127 "EHLO extu-mxob-2.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbYLCMwy (ORCPT ); Wed, 3 Dec 2008 07:52:54 -0500 Date: Wed, 3 Dec 2008 12:52:53 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.anvils To: Andrew Morton cc: dwmw2@infradead.org, jens.axboe@oracle.com, matthew@wil.cx, joern@logfs.org, James.Bottomley@HansenPartnership.com, djshin90@gmail.com, teheo@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/9] swapfile: change discard pgoff_t to sector_t In-Reply-To: <20081202164732.1d6d0997.akpm@linux-foundation.org> Message-ID: References: <20081202164732.1d6d0997.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 18 On Tue, 2 Dec 2008, Andrew Morton wrote: > On Mon, 1 Dec 2008 00:29:41 +0000 (GMT) > Hugh Dickins wrote: > > > - pgoff_t nr_blocks = se->nr_pages << (PAGE_SHIFT - 9); > > + sector_t nr_blocks = se->nr_pages << (PAGE_SHIFT - 9); > > but, but, that didn't change anything? se->nr_pages must be cast to > sector_t? I'm squirming, you are right, thanks for fixing it up. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/