Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754010AbYLCRIk (ORCPT ); Wed, 3 Dec 2008 12:08:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751349AbYLCRIb (ORCPT ); Wed, 3 Dec 2008 12:08:31 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:45675 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbYLCRIb (ORCPT ); Wed, 3 Dec 2008 12:08:31 -0500 Date: Wed, 3 Dec 2008 12:08:29 -0500 From: Christoph Hellwig To: Dave Hansen Cc: Christoph Hellwig , Mimi Zohar , linux-kernel@vger.kernel.org, Andrew Morton , James Morris , Al Viro , David Safford , Serge Hallyn , Mimi Zohar Subject: Re: [PATCH 3/6] integrity: IMA as an integrity service provider Message-ID: <20081203170829.GA32608@infradead.org> References: <5bea2422d059b97475d735feb9feb78b57ec8eca.1228253619.git.zohar@linux.vnet.ibm.com> <1228260925.2971.240.camel@nimitz> <20081203130301.GA9681@infradead.org> <1228323355.2971.259.camel@nimitz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1228323355.2971.259.camel@nimitz> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 22 On Wed, Dec 03, 2008 at 08:55:54AM -0800, Dave Hansen wrote: > On Wed, 2008-12-03 at 08:03 -0500, Christoph Hellwig wrote: > > On Tue, Dec 02, 2008 at 03:35:25PM -0800, Dave Hansen wrote: > > > If you're looking for another way to split your patch out, you could > > > just stick use inode->integrity for the first patch, then introduce your > > > radix-tree in a subsequent patch. It would be functionally fine, and > > > more clearly separate out the ideas. > > > > This was done earlier and is a really bad thing for review. Just as the > > breakout happening in this round. > > If Christoph and I tell you conflicting things, it goes without saying > to listen to Christoph. :) Or listen to what makes more sense. It's not the most important comment of the review anyway.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/