Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356AbYLCRU1 (ORCPT ); Wed, 3 Dec 2008 12:20:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751254AbYLCRUQ (ORCPT ); Wed, 3 Dec 2008 12:20:16 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:44901 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbYLCRUO (ORCPT ); Wed, 3 Dec 2008 12:20:14 -0500 Date: Wed, 3 Dec 2008 11:22:01 -0600 From: "Serge E. Hallyn" To: Mimi Zohar Cc: linux-kernel@vger.kernel.org, Andrew Morton , James Morris , Christoph Hellwig , Al Viro , David Safford , Serge Hallyn , Rajiv Andrade Subject: Re: [PATCH 1/6] integrity: TPM internel kernel interface Message-ID: <20081203172201.GA17036@hallyn.com> References: <1e02b363572908a21f67ff8abbf2b10190a4f6a6.1228253618.git.zohar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1e02b363572908a21f67ff8abbf2b10190a4f6a6.1228253618.git.zohar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 22 Quoting Mimi Zohar (zohar@linux.vnet.ibm.com): > This patch adds internal kernel support for: > - reading/extending a pcr value > - looking up the tpm_chip for a given chip number and type > > Signed-off-by: Mimi Zohar > Signed-off-by: Rajiv Andrade (/me wonders why I can't seem to get any direct emails from you) Dave's comments are good, and I'm sure you'll address them in a followup :), but the basic chip lookup idiom (which as Dave says should be consolidated) does look correct. Acked-by: Serge Hallyn -serge -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/