Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757069AbYLDBId (ORCPT ); Wed, 3 Dec 2008 20:08:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757726AbYLDBHr (ORCPT ); Wed, 3 Dec 2008 20:07:47 -0500 Received: from mail.vyatta.com ([76.74.103.46]:42464 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbYLDBHq (ORCPT ); Wed, 3 Dec 2008 20:07:46 -0500 X-Spam-Flag: NO X-Spam-Score: -1.388 Date: Wed, 3 Dec 2008 17:07:41 -0800 From: Stephen Hemminger To: Dan Williams Cc: linux-kernel@vger.kernel.org, Haavard Skinnemoen , Alexander Beregalov Subject: Re: [PATCH 1/4] dmaengine: add a release for dma class devices and dependent infrastructure Message-ID: <20081203170741.7f25d756@extreme> In-Reply-To: <20081204004646.27790.70015.stgit@dwillia2-linux.ch.intel.com> References: <20081204004514.27790.51174.stgit@dwillia2-linux.ch.intel.com> <20081204004646.27790.70015.stgit@dwillia2-linux.ch.intel.com> Organization: Vyatta X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 25 On Wed, 03 Dec 2008 17:46:46 -0700 Dan Williams wrote: > Resolves: > WARNING: at drivers/base/core.c:122 device_release+0x4d/0x52() > Device 'dma0chan0' does not have a release() function, it is broken and must be fixed. > > The dma_chan_dev object is introduced to gear-match sysfs kobject and > dmaengine channel lifetimes. When a channel is removed access to the > sysfs entries return -ENODEV until the kobject can be released. > > The bulk of the change is updates to existing code to handle the extra > layer of indirection between a dma_chan and its struct device. > > Reported-by: Alexander Beregalov > Cc: Stephen Hemminger > Cc: Haavard Skinnemoen > Signed-off-by: Dan Williams Much better thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/