Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbYLDIHF (ORCPT ); Thu, 4 Dec 2008 03:07:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751073AbYLDIGy (ORCPT ); Thu, 4 Dec 2008 03:06:54 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:41574 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbYLDIGx (ORCPT ); Thu, 4 Dec 2008 03:06:53 -0500 Date: Thu, 4 Dec 2008 09:06:29 +0100 From: Ingo Molnar To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Andrew Morton , Frederic Weisbecker , Peter Zijlstra , Dave Hansen , containers@lists.osdl.org, Eric Biederman , Sukadev Bhattiprolu , "Serge E. Hallyn" , Steven Rostedt Subject: Re: [PATCH 3/3] ftrace: add ability to only trace swapper tasks Message-ID: <20081204080629.GB32594@elte.hu> References: <20081204052638.425740534@goodmis.org> <20081204052735.362609481@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081204052735.362609481@goodmis.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 33 * Steven Rostedt wrote: > From: Steven Rostedt > > Impact: New feature > > This patch lets the swapper tasks of all CPUS be filtered by the > set_ftrace_pid file. > > If '0' is echoed into this file, then all the idle tasks (aka swapper) > is flagged to be traced. This affects all CPU idle tasks. > > Signed-off-by: Steven Rostedt > --- > kernel/trace/ftrace.c | 74 +++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 63 insertions(+), 11 deletions(-) okay, i've applied it - but i dont like the extra complexity of +50 lines at all. This is an area where the 'PID namespaces via struct pid pointers' model breaks down and forces collateral complexity into other subsystems, and where a simple integer based filter is so intuitive. Eric, can you see any way to simplify this? It looks horrible. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/