Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756858AbYLDIn6 (ORCPT ); Thu, 4 Dec 2008 03:43:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752555AbYLDIns (ORCPT ); Thu, 4 Dec 2008 03:43:48 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:41938 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbYLDInr (ORCPT ); Thu, 4 Dec 2008 03:43:47 -0500 Subject: Re: [PATCH 1/3] ftrace: graph of a single function From: Peter Zijlstra To: Ingo Molnar Cc: Steven Rostedt , Andy Whitcroft , Andrew Morton , linux-kernel@vger.kernel.org, fweisbec@gmail.com, arjan@infradead.org, dave@linux.vnet.ibm.com, containers@lists.osdl.org, ebiederm@xmission.com, sukadev@linux.vnet.ibm.com, serue@us.ibm.com, srostedt@redhat.com In-Reply-To: <20081204084118.GG32594@elte.hu> References: <20081203203656.776893226@goodmis.org> <20081203203828.920111079@goodmis.org> <20081203130859.fcf5a51e.akpm@linux-foundation.org> <20081204084118.GG32594@elte.hu> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Thu, 04 Dec 2008 09:43:07 +0100 Message-Id: <1228380187.5092.16.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 34 On Thu, 2008-12-04 at 09:41 +0100, Ingo Molnar wrote: > * Steven Rostedt wrote: > > > > > On Wed, 3 Dec 2008, Andrew Morton wrote: > > > > > On Wed, 03 Dec 2008 15:36:57 -0500 > > > Steven Rostedt wrote: > > > > > > > +static struct seq_operations ftrace_graph_seq_ops = { > > > > + .start = g_start, > > > > + .next = g_next, > > > > + .stop = g_stop, > > > > + .show = g_show, > > > > +}; > > > > > > This could be static I think. > > > > s/static/const/ > > > > Damn damn damn damn!!!! I said to myself, I need to add const there and > > still forgot :-( > > No need to get stressed up about such details - we need checkpatch help > for this. I guess it would be too much for checkpatch, but I think sparse can do it, it just means steve has to install sparse and actually run the thing ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/