Date: Thu, 4 Dec 2008 10:07:17 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Shane McDonald" <mcdonald.shane@gmail.com>
Cc: "Sergei Shtylyov" <sshtylyov@ru.mvista.com>, bzolnier@gmail.com,
       linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Resurrect IT8172 IDE controller driver
Message-ID: <20081204100717.32819f1b@lxorguk.ukuu.org.uk>
In-Reply-To: <b2b2f2320812031839q43eb6102jbae0fbddd9a1cf75@mail.gmail.com>
References: <E1L4UpB-0007ro-1g@localhost>
	<492A8306.9000400@ru.mvista.com>
	<b2b2f2320812031839q43eb6102jbae0fbddd9a1cf75@mail.gmail.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 840
Lines: 16

> I am not sure how to determine if IORDY sampling is supported by a
> drive.  If I'm reading the code correctly, other drivers only check
> that the PIO mode is > 2 (not > 1 as in my driver) -- that seems to be
> the case for at least piix.c, siimage.c, and it8213.c.

Old IDE is wrong on this and in fact unless it has changed recently
simply can't cope with and doesn't provide functions for it. A libata
driver can use the libata helpers but those also rely on the core ata
code doing certain things so if you cut and paste it over you might have
to make other old IDE changes in parallel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/