Date: Thu, 4 Dec 2008 11:12:23 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Jianjun Kong <jianjun@zeuux.org>
Cc: rusty@rustcorp.com.au,
       Linux-Kernel-Mailing-List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] fix warning of not used variable
Message-ID: <20081204101223.GB18708@elte.hu>
References: <20081204010022.GB17445@ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20081204010022.GB17445@ubuntu>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 30


* Jianjun Kong <jianjun@zeuux.org> wrote:

> 
> fix this warning:
> kernel/module.c:824: warning: ‘print_unload_info’ defined but not used
> print_unload_info() just used when CONFIG_PROC_FS was defined.
> 
> Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
> ---
>  kernel/module.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

NAK. Warnings do not need to be "fixed", then need to be looked at and 
then there are two approaches:

 1) GCC is wrong => annotate the code
 2) GCC is right => fix the code

Your patch does not give us any idea about which case this is, whether 
you have analyzed the reason why GCC emitted that warning.

Besides, i dont see such warnings in kernel/module.c with latest GCC.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/