Date: Thu, 4 Dec 2008 13:48:45 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Greg K-H <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG
Message-ID: <20081204134845.6c1df66b@gondolin>
In-Reply-To: <20081203201203.GA3128@redhat.com>
References: <20081202145251.6555d4cc@gondolin>
	<20081203201203.GA3128@redhat.com>
Organization: IBM Deutschland Research & Development GmbH Vorsitzender des
 Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Erich
 Baier Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht:
 Amtsgericht Stuttgart, HRB 243294
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 897
Lines: 25

On Wed, 3 Dec 2008 15:12:03 -0500,
Jason Baron <jbaron@redhat.com> wrote:

> indeed. you raise the more general question of what do if both 'DEBUG'
> and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in
> general the 'DEBUG' should take precedence, as you point out. However, I
> think we should fix this by reshuffling the logic in
> include/linux/kernel.h by doing:
> 
> if (DEBUG)
> 	#define pr_debug printk
> elseif (CONFIG_DYNAMIC_PRINTK_DEBUG)
> 	#define pr_debug dynamic_pr_debug()
> else
> 	#define pr_debug if (0) blah:
> endif
> 
> make sense? what do you think?

Yes, that makes sense, I agree. I'll follow up with a patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/