Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757950AbYLDOqj (ORCPT ); Thu, 4 Dec 2008 09:46:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753993AbYLDOqb (ORCPT ); Thu, 4 Dec 2008 09:46:31 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:63314 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753546AbYLDOqa (ORCPT ); Thu, 4 Dec 2008 09:46:30 -0500 Date: Thu, 4 Dec 2008 09:46:28 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: "Eric W. Biederman" cc: Ingo Molnar , Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , Peter Zijlstra , Dave Hansen , containers@lists.osdl.org, Sukadev Bhattiprolu , "Serge E. Hallyn" , Steven Rostedt Subject: Re: [PATCH 3/3] ftrace: add ability to only trace swapper tasks In-Reply-To: Message-ID: References: <20081204052638.425740534@goodmis.org> <20081204052735.362609481@goodmis.org> <20081204001803.598063f5.akpm@linux-foundation.org> <20081204091023.GJ32594@elte.hu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 31 On Thu, 4 Dec 2008, Eric W. Biederman wrote: > Ingo Molnar writes: > > > * Andrew Morton wrote: > > > >> > Signed-off-by: Steven Rostedt > >> > >> What does this patch actually do? Is swapper currently excluded from > >> tracing for undisclosed reasons and this patch permits it to be traced? > >> If so, why was swapper thus excluded? Or am I totally off track? > > > >> > +static struct pid * const ftrace_swapper_pid = (struct pid *)1; > >> > >> eh? > > > > all side-effects of getting rid of the integer based PID namespace and > > replacing them with struct pid pointers. > > Thanks for asking Andrew it looks like an unnecessary side effect. Well, it was necessary without hacking fork.c ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/