Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756688AbYLDPhb (ORCPT ); Thu, 4 Dec 2008 10:37:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752984AbYLDPhV (ORCPT ); Thu, 4 Dec 2008 10:37:21 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:50282 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148AbYLDPhU (ORCPT ); Thu, 4 Dec 2008 10:37:20 -0500 Date: Thu, 4 Dec 2008 16:36:26 +0100 From: Ingo Molnar To: "Eric W. Biederman" Cc: Andrew Morton , Steven Rostedt , linux-kernel@vger.kernel.org, Frederic Weisbecker , Peter Zijlstra , Dave Hansen , containers@lists.osdl.org, Sukadev Bhattiprolu , "Serge E. Hallyn" , Steven Rostedt Subject: Re: [PATCH 3/3] ftrace: add ability to only trace swapper tasks Message-ID: <20081204153626.GB18293@elte.hu> References: <20081204052638.425740534@goodmis.org> <20081204052735.362609481@goodmis.org> <20081204001803.598063f5.akpm@linux-foundation.org> <20081204091023.GJ32594@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 30 * Eric W. Biederman wrote: > Ingo Molnar writes: > > > * Andrew Morton wrote: > > > >> > Signed-off-by: Steven Rostedt > >> > >> What does this patch actually do? Is swapper currently excluded from > >> tracing for undisclosed reasons and this patch permits it to be traced? > >> If so, why was swapper thus excluded? Or am I totally off track? > > > >> > +static struct pid * const ftrace_swapper_pid = (struct pid *)1; > >> > >> eh? > > > > all side-effects of getting rid of the integer based PID namespace > > and replacing them with struct pid pointers. > > Thanks for asking Andrew it looks like an unnecessary side effect. Will wait for how the end result looks like ;-) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/