Date: Thu, 4 Dec 2008 16:40:44 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       Joakim.Tjernlund@transmode.se
Subject: Re: [PATCH] Allow times and time system calls to return small
	negative values
Message-ID: <20081204154044.GC18293@elte.hu>
References: <18743.25968.602602.875295@drongo.ozlabs.ibm.com> <20081204075751.GA32594@elte.hu> <18743.46549.833800.667962@cargo.ozlabs.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18743.46549.833800.667962@cargo.ozlabs.ibm.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1471
Lines: 39


* Paul Mackerras <paulus@samba.org> wrote:

> Ingo Molnar writes:
> 
> > > +	force_successful_syscall_return();
> > >  	return compat_jiffies_to_clock_t(jiffies);
> > 
> > just curious: what code does force_successful_syscall_return() actually 
> > run in the powerpc case - those bits are missing from this patch. I 
> > suspect it sets some sort of flag?
> 
> It sets the TIF_NOERROR thread flag, which is tested in the syscall 
> exit path along with various other thread flags.
> 
> force_successful_syscall_return() is defined for powerpc in 
> arch/powerpc/include/asm/ptrace.h.  It's nothing new, it has existed 
> for ages and is used in a few other places already.  It has existing 
> non-null definitions on alpha, ia64, powerpc, and sparc64.

ok, was just curious. To make this code nicer, we could keep the time 
syscalls from returning small negative numbers.

the core issue is probably:

 jiffies.h:#define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ))

the thing is, we did INITIAL_JIFFIES to find _in kernel_ jiffies 
wraparoudn bugs (hung timers, broken drivers, etc.) - we did not want to 
confuse userspace with it.

So how about adding INITIAL_JIFFIES to the sys_times() return value?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/