Message-ID: <4938028C.4040905@ru.mvista.com>
Date: Thu, 04 Dec 2008 19:17:16 +0300
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Organization: MontaVista Software Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Shane McDonald <mcdonald.shane@gmail.com>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Resurrect IT8172 IDE controller driver
References: <E1L4UpB-0007ro-1g@localhost>	<492A8306.9000400@ru.mvista.com>	<b2b2f2320812031839q43eb6102jbae0fbddd9a1cf75@mail.gmail.com> <20081204100717.32819f1b@lxorguk.ukuu.org.uk>
In-Reply-To: <20081204100717.32819f1b@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 23

Hello.

Alan Cox wrote:

>>I am not sure how to determine if IORDY sampling is supported by a
>>drive.  If I'm reading the code correctly, other drivers only check
>>that the PIO mode is > 2 (not > 1 as in my driver) -- that seems to be
>>the case for at least piix.c, siimage.c, and it8213.c.

> Old IDE is wrong on this and in fact unless it has changed recently
> simply can't cope with and doesn't provide functions for it. A libata

    It's not as wrong as you're trying to paint it: ide_get_best_pio_mode() 
has been here for ages and it have been returning the IORDY setting -- 
although it actually asks the drive only when auto-tuning the mode, and when 
being given the explicit mode only tells to use IORDY on modes > 2.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/