DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to:
	cc:content-type:content-transfer-encoding;
	b=tdGQKV2iataeB4JRDIt5/ztMS22kFI17taSO9C+ycQ43Rcf7rHvLXdfV3SXexl9wa
	+PjAPIqlM1EKjmholeIbA==
MIME-Version: 1.0
In-Reply-To: <49376BE3.1040909@cn.fujitsu.com>
References: <b040c32a0812032048x4a11dc26k184a4b279b509050@mail.gmail.com>
	 <49376BE3.1040909@cn.fujitsu.com>
Date: Thu, 4 Dec 2008 15:02:31 -0800
Message-ID: <6599ad830812041502m15f54f0ckd8baa0a1792fc31e@mail.gmail.com>
Subject: Re: [patch] export percpu cpuacct cgroup stats
From: Paul Menage <menage@google.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ken Chen <kenchen@google.com>, Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Ingo Molnar <mingo@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 26

On Wed, Dec 3, 2008 at 9:34 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> +
>>  static struct cftype files[] = {
>>       {
>>               .name = "usage",
>>               .read_u64 = cpuusage_read,
>>               .write_u64 = cpuusage_write,
>>       },
>> +     {
>> +             .name = "percpu",
>
> IMO percpu_usage is a better name.
>

Maybe usage_percpu ?

That fits in with the style used in e.g. memory.limit_in_bytes where
the first word is the important quantity, and the subsequent words
indicate some aspect of the quantity.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/