Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754979AbYLEEWT (ORCPT ); Thu, 4 Dec 2008 23:22:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751458AbYLEEWI (ORCPT ); Thu, 4 Dec 2008 23:22:08 -0500 Received: from 136-022.dsl.LABridge.com ([206.117.136.22]:4653 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbYLEEWH (ORCPT ); Thu, 4 Dec 2008 23:22:07 -0500 Subject: Re: [PATCH] Use vprintk rather that vsnprintf where possible From: Joe Perches To: Kay Sievers Cc: Matt Mackall , Andrew Morton , Linux Kernel Mailing List In-Reply-To: References: <1228423309.3255.109.camel@calx> Content-Type: text/plain Date: Thu, 04 Dec 2008 20:21:45 -0800 Message-Id: <1228450905.13046.51.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2-1.2mdv2009.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 22 On Fri, 2008-12-05 at 04:05 +0100, Kay Sievers wrote: > If we convert to two printk calls for a single line, does that not > possibly get mixed up with printks from other locations and lead to > hardly readable log output? Yes it does. There are hundreds of possible interleaves in kernel source today. Adding a couple more isn't horrible. The changes Matt proposes are good because they make the kernel image smaller with a very minimal chance of deciphering difficulty. Someday there'll be a "multiline_printk_start/end" mechanism that will avoid interleaving. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/