Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbYLEFpq (ORCPT ); Fri, 5 Dec 2008 00:45:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751218AbYLEFpe (ORCPT ); Fri, 5 Dec 2008 00:45:34 -0500 Received: from tundra.namei.org ([65.99.196.166]:41486 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbYLEFpd (ORCPT ); Fri, 5 Dec 2008 00:45:33 -0500 Date: Fri, 5 Dec 2008 16:45:15 +1100 (EST) From: James Morris To: "David P. Quigley" cc: hch@infradead.org, viro@zeniv.linux.org.uk, casey@schaufler-ca.com, sds@tycho.nsa.gov, "Matthew N. Dodd" , trond.myklebust@fys.uio.no, bfields@fieldses.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, labeled-nfs@linux-nfs.org Subject: Re: [PATCH 10/14] NFS: Introduce lifecycle management for label attribute. In-Reply-To: <1227733394-1114-11-git-send-email-dpquigl@tycho.nsa.gov> Message-ID: References: <1227733394-1114-1-git-send-email-dpquigl@tycho.nsa.gov> <1227733394-1114-11-git-send-email-dpquigl@tycho.nsa.gov> User-Agent: Alpine 1.10 (LRH 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 541 Lines: 19 On Wed, 26 Nov 2008, David P. Quigley wrote: > +#ifdef CONFIG_NFS_V4_SECURITY_LABEL > + if (nfs_server_capable(dir, NFS_CAP_SECURITY_LABEL)) > + error = nfs_fattr_alloc(&fattr, GFP_NOWAIT); > + if (error < 0) > + goto out_bad; > +#endif Why GFP_NOWAIT ? -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/