Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757403AbYLEM7T (ORCPT ); Fri, 5 Dec 2008 07:59:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751872AbYLEM7J (ORCPT ); Fri, 5 Dec 2008 07:59:09 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:52157 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbYLEM7I (ORCPT ); Fri, 5 Dec 2008 07:59:08 -0500 Date: Fri, 5 Dec 2008 13:58:55 +0100 From: Pavel Machek To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Clemens Ladisch , Geert Uytterhoeven , Krzysztof Helt Subject: Re: [patch 011/104] fbdev: clean the penguins dirty feet Message-ID: <20081205125855.GA1750@ucw.cz> References: <20081203193901.715896543@mini.kroah.org> <20081203194838.GL8950@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081203194838.GL8950@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1998 Lines: 55 On Wed 2008-12-03 11:48:38, Greg KH wrote: > 2.6.27-stable review patch. If anyone has any objections, please let us know. > > ------------------ > From: Clemens Ladisch > > commit cf7ee554f3a324e98181b0ea249d9d5be3a0acb8 upstream. > > When booting in a direct color mode, the penguin has dirty feet, i.e., > some pixels have the wrong color. This is caused by > fb_set_logo_directpalette() which does not initialize the last 32 palette > entries. Heh, funny, but... is this really bad enough bug to go to stable? Pavel > Signed-off-by: Clemens Ladisch > Acked-by: Geert Uytterhoeven > Cc: Krzysztof Helt > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > Signed-off-by: Greg Kroah-Hartman > > --- > drivers/video/fbmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/video/fbmem.c > +++ b/drivers/video/fbmem.c > @@ -232,7 +232,7 @@ static void fb_set_logo_directpalette(st > greenshift = info->var.green.offset; > blueshift = info->var.blue.offset; > > - for (i = 32; i < logo->clutsize; i++) > + for (i = 32; i < 32 + logo->clutsize; i++) > palette[i] = i << redshift | i << greenshift | i << blueshift; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/