Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757859AbYLENaw (ORCPT ); Fri, 5 Dec 2008 08:30:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751138AbYLENao (ORCPT ); Fri, 5 Dec 2008 08:30:44 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:58593 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbYLENao (ORCPT ); Fri, 5 Dec 2008 08:30:44 -0500 Message-ID: <58995.10.75.179.61.1228483840.squirrel@webmail-b.css.fujitsu.com> In-Reply-To: <20081205212529.8d895526.nishimura@mxp.nes.nec.co.jp> References: <20081205212208.31d904e0.nishimura@mxp.nes.nec.co.jp> <20081205212529.8d895526.nishimura@mxp.nes.nec.co.jp> Date: Fri, 5 Dec 2008 22:30:40 +0900 (JST) Subject: Re: [RFC][PATCH -mmotm 4/4] memcg: change try_to_free_pages tohierarchical_reclaim From: "KAMEZAWA Hiroyuki" To: "Daisuke Nishimura" Cc: "LKML" , "linux-mm" , "Balbir Singh" , "KAMEZAWA Hiroyuki" , "Pavel Emelyanov" , "Li Zefan" , "Paul Menage" , nishimura@mxp.nes.nec.co.jp User-Agent: SquirrelMail/1.4.3a X-Mailer: SquirrelMail/1.4.3a MIME-Version: 1.0 Content-Type: text/plain;charset=us-ascii Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 19 Daisuke Nishimura said: > mem_cgroup_hierarchicl_reclaim() works properly even when !use_hierarchy > now, > so, instead of try_to_free_mem_cgroup_pages(), it should be used in many > cases. > > The only exception is force_empty. The group has no children in this case. > Hmm...I postponed this until removing cgroup_lock from reclaim.. But ok, this is a way to go, Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/