Return-Path: <linux-kernel-owner+w=401wt.eu-S1756801AbYLESWM@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756801AbYLESWM (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Dec 2008 13:22:12 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752089AbYLESVz
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 5 Dec 2008 13:21:55 -0500
Received: from cavan.codon.org.uk ([93.93.128.6]:56177 "EHLO
	vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751148AbYLESVy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Dec 2008 13:21:54 -0500
Date: Fri, 5 Dec 2008 18:21:48 +0000
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
       shaohua.li@intel.com, Rafael Wysocki <rwysocki@suse.de>,
       shemminger@linux-foundation.org, netdev@vger.kernel.org,
       Stable@kernel.org
Subject: Re: [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time
Message-ID: <20081205182148.GA28192@srcf.ucam.org>
References: <200811281328.55259.trenn@suse.de> <200812051407.14419.trenn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200812051407.14419.trenn@suse.de>
User-Agent: Mutt/1.5.12-2006-07-14
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: mjg59@codon.org.uk
X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 811
Lines: 23

On Fri, Dec 05, 2008 at 02:07:13PM +0100, Thomas Renninger wrote:

> PCIE: Break out of endless loop waiting for PCI config bits to switch
> 
> Makes a Compaq 6735s boot reliably again which hang in the loop
> on some boots.

Which device does it get stuck on?

> +	if (loop_count == 100) 
> +		dev_printk (KERN_WARNING, &pdev->dev, "Could not configure ASPM\n");

"ASPM: Could not configure common clock\n"? ASPM should still work, 
though with higher latency. It probably also needs to revert the 
configuration changes.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/