Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757497AbYLESjV (ORCPT ); Fri, 5 Dec 2008 13:39:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754570AbYLESis (ORCPT ); Fri, 5 Dec 2008 13:38:48 -0500 Received: from kroah.org ([198.145.64.141]:49039 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754010AbYLESiq (ORCPT ); Fri, 5 Dec 2008 13:38:46 -0500 Date: Fri, 5 Dec 2008 10:36:57 -0800 From: Greg KH To: Tejun Heo Cc: Greg KH , "Theodore Ts'o" , Zwane Mwaikambo , torvalds@linux-foundation.org, Eugene Teo , Justin Forbes , linux-kernel@vger.kernel.org, Chris Wedgwood , Domenico Andreoli , Randy Dunlap , Willy Tarreau , Michael Krufky , alan@lxorguk.ukuu.org.uk, Chuck Ebbert , Jeff Garzik , Dave Jones , akpm@linux-foundation.org, Jake Edge , Chuck Wolber , stable@kernel.org, Rodrigo Rubira Branco Subject: Re: [stable] [patch 067/104] libata: improve phantom device detection Message-ID: <20081205183657.GC2144@kroah.com> References: <20081203193901.715896543@mini.kroah.org> <20081203195323.GP8950@kroah.com> <49375A7F.10407@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49375A7F.10407@kernel.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 44 On Thu, Dec 04, 2008 at 01:20:15PM +0900, Tejun Heo wrote: > > 2.6.27-stable review patch. If anyone has any objections, please let us know. > > > > ------------------ > > From: Tejun Heo > > > > commit 6a6b97d360702b98c02c7fca4c4e088dcf3a2985 upstream. > > > > Currently libata uses four methods to detect device presence. > > > > 1. PHY status if available. > > 2. TF register R/W test (only promotes presence, never demotes) > > 3. device signature after reset > > 4. IDENTIFY failure detection in SFF state machine > > > > Combination of the above works well in most cases but recently there > > have been a few reports where a phantom device causes unnecessary > > delay during probe. In both cases, PHY status wasn't available. In > > one case, it passed #2 and #3 and failed IDENTIFY with ATA_ERR which > > didn't qualify as #4. The other failed #2 but as it passed #3 and #4, > > it still caused failure. > > > > In both cases, phantom device reported diagnostic failure, so these > > cases can be safely worked around by considering any !ATA_DRQ IDENTIFY > > failure as NODEV_HINT if diagnostic failure is set. > > > > Signed-off-by: Tejun Heo > > Signed-off-by: Jeff Garzik > > Signed-off-by: Greg Kroah-Hartman > > Alan thinks this patch could cause regression. Given that we're > nearing the end of 2.6.28-rc cycles, I don't think it's critical to > include this into 2.6.27-stable or at least it can wait a bit more. Ok, I'll transfer it over to the next 2.6.27-stable release. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/