Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755961AbYLESzI (ORCPT ); Fri, 5 Dec 2008 13:55:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752198AbYLESy4 (ORCPT ); Fri, 5 Dec 2008 13:54:56 -0500 Received: from e1.ny.us.ibm.com ([32.97.182.141]:46538 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbYLESyz (ORCPT ); Fri, 5 Dec 2008 13:54:55 -0500 Message-ID: <493978FC.7000502@us.ibm.com> Date: Fri, 05 Dec 2008 12:54:52 -0600 From: Anthony Liguori User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Mark McLoughlin CC: Jiri Slaby , Michael Tokarev , Rusty Russell , linux-kernel , kvm Subject: Re: [PATCH] virtio: make PCI devices take a virtio_pci module ref References: <1228394671.3732.77.camel@blaa> <49385DB7.4060306@gmail.com> <4938EE0B.8020501@msgid.tls.msk.ru> <493929D2.4070900@gmail.com> <1228488921.3858.25.camel@blaa> <49394C1B.2010001@us.ibm.com> <1228502189.3858.57.camel@blaa> In-Reply-To: <1228502189.3858.57.camel@blaa> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 54 Mark McLoughlin wrote: > On Fri, 2008-12-05 at 09:43 -0600, Anthony Liguori wrote: > >> Mark McLoughlin wrote: >> >>> On Fri, 2008-12-05 at 14:17 +0100, Jiri Slaby wrote: >>> >>> +static void virtio_pci_release_dev(struct device *dev) >>> +{ >>> +} >>> + >>> /* A PCI device has it's own struct device and so does a virtio device so >>> * we create a place for the virtio devices to show up in sysfs. I think it >>> * would make more sense for virtio to not insist on having it's own device. */ >>> static struct device virtio_pci_root = { >>> .parent = NULL, >>> .bus_id = "virtio-pci", >>> + .release = virtio_pci_release_dev, >>> }; >>> >>> >> Actually, we should be able to delete this virtio_pci_root entirely. >> The device is a dummy one anyway. >> > > Care to recall why it was added initially and what's changed? > > One side effect of removing it is that each device appears on its own > in /sys/devices rather than neatly under /sys/devices/virtio-pci. > Basically, to get the neater sysfs hierarchy. But it seems that this requires Evil Things so I'm inclined to say it's not worth it. > (And one side effect of that is that the aforementioned Fedora mkinitrd > kludge stops working which would make me sad :-) > Yeah, that would be unfortunate. Can the kludge be done differently? Regards, Anthony Liguori > Cheers, > mark. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/