Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757503AbYLFCxT (ORCPT ); Fri, 5 Dec 2008 21:53:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755253AbYLFCxD (ORCPT ); Fri, 5 Dec 2008 21:53:03 -0500 Received: from kroah.org ([198.145.64.141]:50237 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754971AbYLFCxA (ORCPT ); Fri, 5 Dec 2008 21:53:00 -0500 Date: Fri, 5 Dec 2008 18:45:08 -0800 From: Greg KH To: Linus Torvalds Cc: "Rafael J. Wysocki" , Frans Pop , Ingo Molnar , jbarnes@virtuousgeek.org, lenb@kernel.org, Linux Kernel Mailing List , tiwai@suse.de, Andrew Morton Subject: Re: Regression from 2.6.26: Hibernation (possibly suspend) broken on Toshiba R500 (bisected) Message-ID: <20081206024508.GA5099@kroah.com> References: <200812020320.31876.rjw@sisk.pl> <200812060104.50050.rjw@sisk.pl> <200812060218.13030.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 37 On Fri, Dec 05, 2008 at 05:55:16PM -0800, Linus Torvalds wrote: > > > On Sat, 6 Dec 2008, Rafael J. Wysocki wrote: > > > > It only affects the legacy handling, but the non-legacy handling was left > > untouched. IOW, the old "default" functions are still there and are being > > called by the "non-legacy" code (it's only used by USB at the moment, AFAICS). > > Ok. > > > Anyway, I did the test doing it only to the devices which don't have any > > non-default suspend-resume handling at all and _that_ apparently fixed the > > problem on my box. :-) > > Which makes sense, btw. Because if you do the pci_save_state() on a device > that _does_ have a suspend function, you'll be saving the post-suspend > state - ie the device turned off. I think that is why we did not do it for every device, we didn't want to touch drivers that already had working suspend calls. > So yeah, we really can only do the default suspend if the device has no > pre-existing suspend function - or we'd need to make sure that all PCI > drivers that do have suspend functions would only do the higher-level > functionality. Agreed. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/