Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756269AbYLFIky (ORCPT ); Sat, 6 Dec 2008 03:40:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751250AbYLFIkp (ORCPT ); Sat, 6 Dec 2008 03:40:45 -0500 Received: from vps1.tull.net ([66.180.172.116]:47492 "HELO vps1.tull.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750779AbYLFIkp (ORCPT ); Sat, 6 Dec 2008 03:40:45 -0500 Date: Sat, 6 Dec 2008 19:40:38 +1100 From: Nick Andrew To: Joe Perches Cc: Andrew Morton , Linux Kernel Mailing List , Linus Torvalds , Tejun Heo , Takashi Iwai Subject: Re: [RFC] Recursive printk Message-ID: <20081206084038.GG5957@mail.local.tull.net> References: <20081206065922.29149.63380.stgit@marcab.local.tull.net> <20081205232016.366765e2.akpm@linux-foundation.org> <1228549357.13046.618.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1228549357.13046.618.camel@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) X-SMTPD: qpsmtpd/0.26, http://develooper.com/code/qpsmtpd/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 19 On Fri, Dec 05, 2008 at 11:42:37PM -0800, Joe Perches wrote: > I think recursive printk is poor style and > should be avoided. I think this is one of those cases where it's a lot harder (or uglier) to solve a problem non-recursively than it is to solve recursively. The basic problem is that subsystems want to prepend or append their own data to kernel messages generated by subsystem code, and they both want to use printf-type strings. How to combine them into a single kernel log message without using extra memory, or double handling of strings? Nick. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/