From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Rakib Mullick" <rakib.mullick@gmail.com>
Subject: Re: [PATCH] kernel/freezer.c : Removing extra checking.
Date: Sat, 6 Dec 2008 14:41:15 +0100
User-Agent: KMail/1.9.9
Cc: "Linux-kernel Mailing List" <linux-kernel@vger.kernel.org>,
       "Ingo Molnar" <mingo@elte.hu>,
       "Andrew Morton" <akpm@linux-foundation.org>
References: <b9df5fa10812060020i40373ed3rdc97812ed46ba959@mail.gmail.com>
In-Reply-To: <b9df5fa10812060020i40373ed3rdc97812ed46ba959@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200812061441.15772.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1190
Lines: 31

On Saturday, 6 of December 2008, Rakib Mullick wrote:
> Impact: Reduces an extra checking.
> 
> Following patch removes an extra checking. We can remove it since, the
> current task is frozen. If the current task is not frozen, then it
> will return from __else__ condition of freezing(current) check. So,
> the check becames unnecessary. It also reduces 32 bytes of text space
> on my x86  (32 bit) system.

What will happen with this patch applied when a task is woken up for some
reason other than thawing?

> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> 
> --- linux-2.6-orig/kernel/freezer.c	2008-12-05 19:53:45.000000000 +0600
> +++ linux-2.6/kernel/freezer.c	2008-12-05 19:55:40.000000000 +0600
> @@ -46,8 +46,6 @@ void refrigerator(void)
> 
>  	for (;;) {
>  		set_current_state(TASK_UNINTERRUPTIBLE);
> -		if (!frozen(current))
> -			break;
>  		schedule();
>  	}
>  	pr_debug("%s left refrigerator\n", current->comm);
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/