From: Frans Pop <elendil@planet.nl>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [patch,rfc] usb: restore config before enabling device on resume
Date: Sat, 6 Dec 2008 16:02:23 +0100
User-Agent: KMail/1.9.9
Cc: Linus Torvalds <torvalds@linux-foundation.org>, Greg KH <greg@kroah.com>,
       Ingo Molnar <mingo@elte.hu>, jbarnes@virtuousgeek.org, lenb@kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, tiwai@suse.de,
       Andrew Morton <akpm@linux-foundation.org>,
       USB list <linux-usb@vger.kernel.org>
References: <200812020320.31876.rjw@sisk.pl> <200812061020.19546.elendil@planet.nl> <200812061448.31468.rjw@sisk.pl>
In-Reply-To: <200812061448.31468.rjw@sisk.pl>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200812061602.26002.elendil@planet.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 792
Lines: 17

On Saturday 06 December 2008, Rafael J. Wysocki wrote:
> In fact, I think you could even move the pci_restore_state(dev) into
> usb_hcd_pci_resume_early() that would be executed with interrupts off
> and drop the pci_set_power_state(dev, PCI_D0); entirely (the
> pci_enable_device(dev); would invoke it anyway).

There is quite a lot going on in the resume function that happens before 
pci_restore_state is called and I'm absolutely not confident with messing 
with that, so I'll leave anything more invasive to the USB maintainers.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/