Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479AbYLFUdc (ORCPT ); Sat, 6 Dec 2008 15:33:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752654AbYLFUdY (ORCPT ); Sat, 6 Dec 2008 15:33:24 -0500 Received: from ey-out-2122.google.com ([74.125.78.24]:60609 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbYLFUdX (ORCPT ); Sat, 6 Dec 2008 15:33:23 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=jKeJYHvzCgmgapkPyX5TkGJttsqFInFrU5TUIjylAa4pOkp9HJRvfJCWwYbQCzIHRf Hi/o5Nb3oSDgd24aOzo4CrsV8L/6fFX/IjkySAxe6EVc3G50PoseyNj3EViipZyueiQo 4JW+BiYy+3GQTs6GLXrgBMCb7Uyui9y7Pt6MM= Date: Sat, 6 Dec 2008 23:37:40 +0300 From: Alexey Dobriyan To: Alexander Beregalov Cc: gregkh@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: convert to list_for_each() Message-ID: <20081206203740.GA2264@x200.localdomain> References: <20081206184905.GA19589@orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081206184905.GA19589@orion> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 21 On Sat, Dec 06, 2008 at 09:49:05PM +0300, Alexander Beregalov wrote: No, switch to list_for_each_entry() from the very beginning. > --- a/drivers/staging/me4000/me4000.c > +++ b/drivers/staging/me4000/me4000.c > @@ -542,8 +542,7 @@ static void clear_board_info_list(void) > struct me4000_ao_context *ao_context; > > /* Clear context lists */ > - for (board_p = me4000_board_info_list.next; > - board_p != &me4000_board_info_list; board_p = board_p->next) { > + list_for_each(board_p, &me4000_board_info_list) { > board_info = list_entry(board_p, struct me4000_info, list); > /* Clear analog output context list */ > while (!list_empty(&board_info->ao_context_list)) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/