Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884AbYLFXZQ (ORCPT ); Sat, 6 Dec 2008 18:25:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753298AbYLFXZD (ORCPT ); Sat, 6 Dec 2008 18:25:03 -0500 Received: from casper.infradead.org ([85.118.1.10]:60350 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310AbYLFXZC (ORCPT ); Sat, 6 Dec 2008 18:25:02 -0500 Date: Sat, 6 Dec 2008 15:25:45 -0800 From: Arjan van de Ven To: Linus Torvalds Cc: "Rafael J. Wysocki" , Alan Stern , Takashi Iwai , Greg KH , LKML , Jesse Barnes , pm list , Ingo Molnar , Andrew Morton Subject: Re: [linux-pm] [PATCH 1/3] PCI: Rework default handling of suspend and resume Message-ID: <20081206152545.326c8b67@infradead.org> In-Reply-To: References: <200812062236.44111.rjw@sisk.pl> Organization: Intel X-Mailer: Claws Mail 3.6.0 (GTK+ 2.14.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 29 On Sat, 6 Dec 2008 14:24:55 -0800 (PST) Linus Torvalds wrote: > > > On Sat, 6 Dec 2008, Rafael J. Wysocki wrote: > > > > However, I'm not quite sure about the freeing and requesting IRQs > > during suspend and resume. Many drivers do that, many others > > don't. Still, apparently some drivers don't work correctly after > > resume if this is not done. So, if that should generally be done, I > > also think that moving it to the core might be a good idea. > > I'd suggest against it. > > A lot of drivers that want to disable (or unregister) interrupts > almost certainly want to do it simply because they are not ready and > willing to handle any interrupts after having run their "suspend()" > function. the problem is that the system bios can have reassigned interrupts after resume, and afaik we need to re-evaluate the ACPI methods to get the new mapping. So we need to unregister + re-register to make that happen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/