Message-ID: <493B42D1.7090600@shaw.ca>
Date: Sat, 06 Dec 2008 21:28:17 -0600
From: Robert Hancock <hancockr@shaw.ca>
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
CC: Frans Pop <elendil@planet.nl>, "Rafael J. Wysocki" <rjw@sisk.pl>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] ohci1394: don't leave interrupts enabled during suspend/resume
References: <200812061316.38460.elendil@planet.nl> <200812061536.47894.elendil@planet.nl> <493AE8B3.7090000@shaw.ca> <tkrat.fd592eed61e41b8f@s5r6.in-berlin.de>
In-Reply-To: <tkrat.fd592eed61e41b8f@s5r6.in-berlin.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1004
Lines: 23

Stefan Richter wrote:
> Robert Hancock wrote:
>> If free_irq and 
>> request_irq fix anything, then that indicates that the ohci1394 device 
>> is generating interrupts at some point during resume,
> ...
>> Likely the driver should be setting some register on the device to 
>> disable it from generating interrupts before suspend and it's not doing 
>> this.
> 
> 	reg_write(ohci, OHCI1394_IntMaskClear, 0xffffffff);
> 
> in ohci1394's .suspend() switches interrupts off.

Presumably it should.. but the fact remains that if free_irq helps 
anything, then the device must be generating interrupts for some reason, 
and it's really just papering over the problem. Perhaps a quirk of that 
particular chip? Something to do with the state it's in after resume?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/