Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbYLGLWj (ORCPT ); Sun, 7 Dec 2008 06:22:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753411AbYLGLWb (ORCPT ); Sun, 7 Dec 2008 06:22:31 -0500 Received: from mo-p00-ob.rzone.de ([81.169.146.160]:16545 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbYLGLWb (ORCPT ); Sun, 7 Dec 2008 06:22:31 -0500 X-RZG-CLASS-ID: mo00 X-RZG-AUTH: :I2ANY0W6W/eA95XfH/xfO6gOxLxTty/udEMngcJ/VAKW226lDNJVyuUOJDI/MLAx Message-ID: <493BB1EB.5000004@hartkopp.net> Date: Sun, 07 Dec 2008 12:22:19 +0100 From: Oliver Hartkopp User-Agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018) MIME-Version: 1.0 To: Peter Zijlstra CC: Thomas Gleixner , Ingo Molnar , linux-kernel , Linus Torvalds Subject: Re: [RFC PATCH] hrtimer: removing all ur callback modes References: <1227613431.4259.1537.camel@twins> <1228385830.5092.43.camel@twins> In-Reply-To: <1228385830.5092.43.camel@twins> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 38 Peter Zijlstra wrote: > On Tue, 2008-11-25 at 12:43 +0100, Peter Zijlstra wrote: > >> Hi, >> >> This is an attempt at removing some of the hrtimer complexity by >> reducing the number of callback modes to 1. >> >> This means that all hrtimer callback functions will be ran from HARD-irq >> context. >> >> I went through all the 30 odd hrtimer callback functions in the kernel >> and saw only one that I'm not quite sure of, which is the one in >> net/can/bcm.c - hence I'm CC-ing the folks responsible for that code. >> Thanks Peter. Indeed i assumed my hrtimer callbacks to run in soft-irq. I tried the can-bcm protocol with Ingos current linux-2.6-sched-devel.git including your patches and i did not see any issues so far. And i do not expect any (recursion) problems with hrtimer_forward() in my code either. But i'm not that familiar with the timer context's stuff, that i would like guaranty that the functions i use in bcm_send_user() and in bcm_can_tx() are always safe to be used in hard-irq context. It would be nice, if you could give me some support by double checking the correctness of the hard-irq context in the given functions. Best regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/