Date: Mon, 8 Dec 2008 09:47:21 +1100 (EST)
From: James Morris <jmorris@namei.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
cc: "Serge E. Hallyn" <serue@us.ibm.com>, lkml <linux-kernel@vger.kernel.org>,
       David Howells <dhowells@redhat.com>,
       Michael Kerrisk <mtk.manpages@gmail.com>,
       Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] user namespaces: require cap_set{ug}id for
 CLONE_NEWUSER
In-Reply-To: <m1r64mpmsi.fsf@frodo.ebiederm.org>
Message-ID: <alpine.LRH.1.10.0812080947050.23851@tundra.namei.org>
References: <20081203191706.GA16433@us.ibm.com> <20081203191733.GA16652@us.ibm.com> <m1r64mpmsi.fsf@frodo.ebiederm.org>
User-Agent: Alpine 1.10 (LRH 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 28

On Fri, 5 Dec 2008, Eric W. Biederman wrote:

> "Serge E. Hallyn" <serue@us.ibm.com> writes:
> 
> > While ideally CLONE_NEWUSER will eventually require no
> > privilege, the required permission checks are currently
> > not there.  As a result, CLONE_NEWUSER has the same effect
> > as a setuid(0)+setgroups(1,"0").  While we already require
> > CAP_SYS_ADMIN, requiring CAP_SETUID and CAP_SETGID seems
> > appropriate.
> 
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> 
> The patch looks good, and we are likely to need more caps to
> actually use it.

Applied to 
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


-- 
James Morris
<jmorris@namei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/