Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755559AbYLHBc6 (ORCPT ); Sun, 7 Dec 2008 20:32:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753287AbYLHBcp (ORCPT ); Sun, 7 Dec 2008 20:32:45 -0500 Received: from mga01.intel.com ([192.55.52.88]:39494 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbYLHBcp (ORCPT ); Sun, 7 Dec 2008 20:32:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.33,732,1220252400"; d="scan'208";a="412334033" Subject: Re: [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time From: Shaohua Li To: Matthew Garrett Cc: Thomas Renninger , "linux-kernel@vger.kernel.org" , "jbarnes@virtuousgeek.org" , Rafael Wysocki , "shemminger@linux-foundation.org" , "netdev@vger.kernel.org" , "Stable@kernel.org" In-Reply-To: <20081205182148.GA28192@srcf.ucam.org> References: <200811281328.55259.trenn@suse.de> <200812051407.14419.trenn@suse.de> <20081205182148.GA28192@srcf.ucam.org> Content-Type: text/plain Date: Mon, 08 Dec 2008 09:32:42 +0800 Message-Id: <1228699962.13024.2.camel@sli10-desk.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 28 On Sat, 2008-12-06 at 02:21 +0800, Matthew Garrett wrote: > On Fri, Dec 05, 2008 at 02:07:13PM +0100, Thomas Renninger wrote: > > > PCIE: Break out of endless loop waiting for PCI config bits to switch > > > > Makes a Compaq 6735s boot reliably again which hang in the loop > > on some boots. > > Which device does it get stuck on? > > > + if (loop_count == 100) > > + dev_printk (KERN_WARNING, &pdev->dev, "Could not configure ASPM\n"); > > "ASPM: Could not configure common clock\n"? ASPM should still work, > though with higher latency. It probably also needs to revert the > configuration changes. Yep, Just undo the pci config writes of pcie_aspm_configure_common_clock should be fine to me. Maybe an expiration time is ok here. Does the device work after this? Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/