Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbYLHMxf (ORCPT ); Mon, 8 Dec 2008 07:53:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752030AbYLHMx0 (ORCPT ); Mon, 8 Dec 2008 07:53:26 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:38744 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbYLHMx0 (ORCPT ); Mon, 8 Dec 2008 07:53:26 -0500 Date: Mon, 8 Dec 2008 13:53:19 +0100 From: Ingo Molnar To: Ken Chen Cc: Peter Zijlstra , Linux Kernel Mailing List Subject: Re: [patch] sched: fix sd_parent_degenerate on non-numa smp machine Message-ID: <20081208125319.GD16560@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 958 Lines: 23 * Ken Chen wrote: > The addition of SD_SERIALIZE flag added to SD_NODE_INIT prevented top level > dummy numa sched_domain to be properly degenerated on non-numa smp machine. > The reason is that in sd_parent_degenerate(), it found that the child and > parent does not have comon sched_domain flags due to SD_SERIALIZE. However, > for non-numa smp box, the top level is a dummy with a single sched_group. > > Filter out SD_SERIALIZE if it is on non-numa machine to properly degenerate > top level node sched_domain. this will cut back some of the sd domain walk > in the load balancer code. > > Signed-off-by: Ken Chen applied to tip/sched/core, thanks Ken! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/